node-eventstore-client icon indicating copy to clipboard operation
node-eventstore-client copied to clipboard
verified publisher icon nicdex

Typescript definitions are incomplete

Open nicdex opened this issue 7 years ago • 3 comments

nicdex avatar Feb 19 '18 01:02 nicdex

EventStoreNodeConnection inherits from EventEmitter but the removeListener methods are missing at the declaration. Would be nice to get them.

Ulrikop avatar Feb 08 '19 18:02 Ulrikop

I don't use typescript much, this is why the definitions are not well tested and incomplete. It would help a lot if someone could provide a PR for this.

nicdex avatar Feb 08 '19 21:02 nicdex

I'm not so deep inside the node-eventstore-client because that I can't recheck the whole declarations so easily. But I added my requested EventEmitter support to EventStoreNodeConnection at PR #66

But that change needs a minim version 2.8 of the TypeScript compile now. If that is not ok, the event checking must be removed (that only the right event can be used and that the handlers uses the right param type)

Ulrikop avatar Feb 09 '19 12:02 Ulrikop