implicit-depth icon indicating copy to clipboard operation
implicit-depth copied to clipboard

HypersimDataset is missing

Open brotherofken opened this issue 2 years ago • 2 comments

Hi there!

I wanted to express my gratitude for making your research results publicly available and for releasing the source code.

While digging through the code base, I noticed that the implementation of HypersimDataset is missing but mentioned in the dataset_utils.py. I wanted to confirm whether this omission is intentional or if it occurred inadvertently during the process of making the code publicly available.

Best regards, Rasim.

brotherofken avatar May 29 '23 14:05 brotherofken

Hello Rasim,

We're planning on releasing a HyperSim dataset class soon. Hang tight!

Mohamed

mohammed-amr avatar May 30 '23 10:05 mohammed-amr

That will be extremely helpful!

Right now I'm working on Hypersim converter by myself and have encountered a few issues which have to be adressed carefully.

  1. Firstly, the depth maps seem to contain distance to the camera center instead of the actual depth. https://github.com/apple/ml-hypersim/issues/9
  2. Secondly, there are a few scenes with corrupted frames, which need to be excluded. https://github.com/apple/ml-hypersim/issues/22#issuecomment-888614249 which have to be excluded.
  3. Per scene intrincics must be used as prescribed here: https://github.com/apple/ml-hypersim/tree/main/contrib/mikeroberts3000 upd. actually one has to reproject tilt-shifted images to bring intrinsics matrix to "standart" form.
  4. Not an issue, but tonemapping needs to be applied. https://github.com/apple/ml-hypersim/blob/main/code/python/tools/scene_generate_images_tonemap.py#L76

If you have a spare minute, could you please let me know if there are any other important details that I might be missing?

brotherofken avatar May 31 '23 17:05 brotherofken

Hi, sorry for the delay! We have just merged the Hypersim code, please check the README! :)

qureshizawar avatar May 30 '24 12:05 qureshizawar