nidaqmx-python icon indicating copy to clipboard operation
nidaqmx-python copied to clipboard

PR build should run ni-python-styleguide on all handwritten code

Open bkeryan opened this issue 1 year ago • 0 comments

src/handwritten is currently excluded from both [tool.black] and [tool.ni-python-styleguide]: https://github.com/ni/nidaqmx-python/blob/master/pyproject.toml#L77

[tool.black]
line-length = 100
extend_exclude = ".tox/|docs/|generated/|src/codegen/metadata/|src/codegen/templates/|src/handwritten/"

[tool.ni-python-styleguide]
extend_exclude = ".tox,docs,generated,src/codegen/metadata,src/codegen/templates,src/handwritten"

We should:

  • Remove this exclusion
  • Run ni-python-styleguide fix
  • Run ni-python-styleguide acknowledge-existing-violations
  • Update the copy in generated/nidaqmx

bkeryan avatar Apr 02 '24 20:04 bkeryan