scopehal-apps icon indicating copy to clipboard operation
scopehal-apps copied to clipboard
verified publisher icon ngscopeclient

Patch for adding Lecroy Waverunner 7000A series support

Open nctnico opened this issue 9 months ago • 2 comments

The attached patch adds support for Lecroy Waverunner 7000A series.

The Lecroy 7000A series is related to the Lecroy DDA-5k series.

  • Added model detection and bandwidths for 7100A, 7200A and 7300A
  • Modified channel detection. Default to 4 channels (I have not seen the higher end Lecroys have less than 4 channels) and removed the model number based channel detection as this is not a good default action.
  • Added exception to numeric conversion (this crashed ngoscopeclient in some occasions)
  • Fixed compilation error due to ;; in scopehal.h

Waverunner-7000A.patch.txt

nctnico avatar Apr 23 '25 09:04 nctnico

Can you please resubmit this as a pull request against https://github.com/ngscopeclient/scopehal/ so we can properly review and merge? This patch doesn't actually change any files in this repository :)

azonenberg avatar Apr 23 '25 15:04 azonenberg

I tried to push the feature branch to create a pull request but the push is not working. I'm not a master at dealing with git 'things' though.

nctnico avatar Apr 23 '25 17:04 nctnico