platform icon indicating copy to clipboard operation
platform copied to clipboard

Add the new function loadWithQuery to ngrx data extension point class DefaultDataService

Open bhahn57570 opened this issue 2 years ago • 0 comments

Which @ngrx/* package(s) are relevant/related to the feature request?

data

Information

Recently in EntityCollectionServiceBase, the function loadWithQuery(queryParams: string | QueryParams, options?: EntityActionOptions): Observable<T[]> was added. Currently, in the DefaultDataService, we can override the function getWithQuery, if we call loadwithquery it is simply passing through getWithQuery but is not reacting as expected. Can the new function loadWithQuery be added to DefaultDataService? It is helpful in the case we want to fill a table with server pagination by the content of the observable entities$.

Describe any alternatives/workarounds you're currently using

Currently, we have to use the function clearCache and then getWithQuery to replace the whole entity store.,

I would be willing to submit a PR to fix this issue

  • [ ] Yes
  • [x] No

bhahn57570 avatar Jun 04 '23 09:06 bhahn57570