ngneat
[Bug] Release workflow failing on new angular cli projects
I'm submitting a...
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:
Current behavior
The release.yml workflow fails on a angular cli project using v12+.
There is no linter included by default anymore but the workflow includes a lint script.
Expected behavior
The schematic should either:
- remove the lint part of the GitHub Action (I would discourage such option as linting a project is a good practice)
- add a linter
Minimal reproduction of the problem with instructions
Create an angular project with the cli (v12+) Add ngneat lib push changes on GitHub Look at GitHub Actions logs
What is the motivation / use case for changing the behavior?
As the ng add schematic runs prompts firstly, there is no way to know if a linter is already included in the project before proposing to add one or to update the release.yml file.
I don't know if there are @angular-eslint/schematics npm package alternatives being used by the community. Otherwise, checking it in the schematic and running externalSchematic("@angular-eslint/schematics", "ng-add", options) can be solution.
The options to use would need to be defined as well.
Others:
Once accepted as a valid change, I will communicate to encourage people to submit a PR.
Sounds good. I think we should remove linter from GH action. Because I think it will be difficult to manage one more task of adding linter.
