lib icon indicating copy to clipboard operation
lib copied to clipboard

[Feature Request] Add an option for the default git branch

Open geromegrignon opened this issue 4 years ago • 3 comments

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

The deploy.yml workflow is triggered with push events on the master branch.

Expected behavior

Add an option in the schematic to set the name of the default branch used by the project

What is the motivation / use case for changing the behavior?

As GitHub promotes main for the default branch, it might lead to confusion for people not used to GitHub Actions and the workflow not being triggered as they would expect.

Others:

Once accepted as a valid change, I will communicate to encourage people to submit a PR.

geromegrignon avatar Jan 09 '22 20:01 geromegrignon

Ideally, deployment should happen ideally from mast or main branch only, right?

shhdharmen avatar Jan 12 '22 14:01 shhdharmen

Right. As that is more likely the default branch, it might be changed to ${{ github.event.repository.default_branch }}

geromegrignon avatar Jan 12 '22 14:01 geromegrignon

Yes, we can make that change.

shhdharmen avatar Jan 13 '22 07:01 shhdharmen