lib icon indicating copy to clipboard operation
lib copied to clipboard

[Bug] outdated angular-cli-ghpages version for nx projects

Open geromegrignon opened this issue 4 years ago • 1 comments

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

By running ng add @ngneat/lib <lib-name> in a Nx project, the schematic fails on ng add angular-cli-ghpages part.

SchematicsException [Error]: No Angular project selected and no default project in the workspace
    at /Users/geromegrignon/Documents/workspace/oneshots/foo/node_modules/angular-cli-ghpages/ng-add.js:25:19
    at Generator.next (<anonymous>)
    at fulfilled (/Users/geromegrignon/Documents/workspace/oneshots/foo/node_modules/angular-cli-ghpages/ng-add.js:5:58)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)

Expected behavior

The schematic should find the defaultProject info.

It's due to the angular-cli-ghpages version used. Changes occurred in the lib with this commit.

ng add angular-cli-ghpages with latest version (v1.0.0) in a nx project works as expected

Minimal reproduction of the problem with instructions

create a nx workspace with npx create-nx-workspace --preset=angular. run ng add @ngneat/lib <lib-name>

Changes required

Change angular-cli-ghpages version used in the schematic to v1.0.0.

Others:

Once accepted as a valid change, I will communicate to encourage people to submit a PR to fix it.

geromegrignon avatar Jan 09 '22 20:01 geromegrignon

Sound good.

shhdharmen avatar Jan 12 '22 11:01 shhdharmen