lib icon indicating copy to clipboard operation
lib copied to clipboard

[Feature Request] change GitHub secret name for deploy GitHub Action

Open geromegrignon opened this issue 4 years ago • 3 comments

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

The deploy.yml workflow requires the creation of a GH_TOKEN secret.

Expected behavior

At the start of each workflow run, GitHub creates a related secret named `GITHUB_TOKEN. Related doc here

What is the motivation / use case for changing the behavior?

By renaming the name of the secret, it would prevent a manual step when using the schematic to add this workflow.

Others:

Once accepted as a valid change, I will communicate to encourage people to submit a PR.

geromegrignon avatar Jan 09 '22 17:01 geromegrignon

Sounds good.

shhdharmen avatar Jan 12 '22 11:01 shhdharmen

Why do you need the deploy.yml?

NetanelBasal avatar Jan 12 '22 11:01 NetanelBasal

Opps wrong repo :)

NetanelBasal avatar Jan 12 '22 11:01 NetanelBasal