lib icon indicating copy to clipboard operation
lib copied to clipboard

chore(github): move existing template to new issue forms format

Open geromegrignon opened this issue 4 years ago • 3 comments

remove md templates add yml templates update tests

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: CONTRIBUTING.md#commit
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Github introduced the new Issue Forms format for issue templates: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#creating-issue-forms

This PR updates the existing templates (both on the project and the schematics) to this new format. You can see the result on ngneat/edit-in-place.

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[] Documentation content changes
[x] Other... Please describe: Github Feature

What is the current behavior?

The existing template provides a field to complete by updating its unique content.

Issue Number: N/A

What is the new behavior?

The Github Issue Forms format provides a better user experience while avoiding sections being deleted.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

I used an Angular app I created to generate the yaml content of this template : https://issue-forms-creator.app/new

geromegrignon avatar Jul 08 '21 12:07 geromegrignon

Issue forms feature is still in beta, I think we should wait until they make it prod ready. image

shhdharmen avatar Jul 09 '21 05:07 shhdharmen

Sure, closing this PR by now.

geromegrignon avatar Jul 09 '21 05:07 geromegrignon

There is no need to close it. We'll merge it when the feature will be prod ready. Thanks!

NetanelBasal avatar Jul 09 '21 05:07 NetanelBasal