ngx-rust icon indicating copy to clipboard operation
ngx-rust copied to clipboard

WIP: updating naming conventions

Open f5yacobucci opened this issue 2 years ago • 3 comments

Consistently use _ptr and _mut_ptr for our functions that return *mut and *const pointers.

  • [ ] I have written my commit messages in the Conventional Commits format.
  • [ ] I have read the CONTRIBUTING doc
  • [ ] I have added tests (when possible) that prove my fix is effective or that my feature works
  • [ ] I have checked that all unit tests pass after adding my changes
  • [ ] I have updated necessary documentation
  • [ ] I have rebased my branch onto master
  • [ ] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

f5yacobucci avatar Sep 01 '23 21:09 f5yacobucci

I did not update the Module trait function names, as these match 1:1 with the NGINX names I left them untouched and consistent with the C naming semantics.

f5yacobucci avatar Sep 01 '23 21:09 f5yacobucci

TODO: update README with a conventions section

f5yacobucci avatar Sep 01 '23 21:09 f5yacobucci

@f5yacobucci Is this PR now obsolete?

dekobon avatar May 02 '24 01:05 dekobon