node-bestzip icon indicating copy to clipboard operation
node-bestzip copied to clipboard

Empty directories are not zipped

Open s-pic opened this issue 7 years ago • 4 comments

I figured out that if I do not put a file in a directory, it will not go into the archive. Is there some sort of option I can use?

Here is what I am doing: cd build && bestzip ../myproject-build.zip * .env.example

/build contains files, subfolders with files and also empty subfolders.

I am on a windows machine.

s-pic avatar Dec 06 '18 12:12 s-pic

Hi @geomC,

Can you try running the command with --force=node and --force=native and let me know what the results are for each variation?

nfriedly avatar Dec 06 '18 23:12 nfriedly

Actually, nevermind. I made a test case that reproduces the bug, so now I just need to figure out how to fix it.

nfriedly avatar Dec 07 '18 01:12 nfriedly

...2 years later ahah

No fix planned ? This issue is blocking me in my delivery process :(

Kovvah avatar Apr 14 '21 16:04 Kovvah

Sorry, this was from right before my daughter was born, and everything got more or less forgotten after that.

If you can come up with a fix (and hopefully a test, since I'm not sure what happened to the one I made), I can get it merged in and shipped pretty soon.

nfriedly avatar Apr 14 '21 16:04 nfriedly