zenpush icon indicating copy to clipboard operation
zenpush copied to clipboard

Finding a category forum by name incorrectly selects first forum with that name, regardless of category

Open alexkwolfe opened this issue 12 years ago • 0 comments

There is a bug in the #find_forum and #find_or_create_forum methods.

Those methods attempt to locate forum by category name and forum name. In the case where different categories have forums with the same name, then a forum from the wrong category may be returned in error.

The fix is to ensure that the forum comparison uses the category ID in addition to the forum name.

A pull request is forthcoming.

alexkwolfe avatar Jun 11 '13 18:06 alexkwolfe