react-gpt icon indicating copy to clipboard operation
react-gpt copied to clipboard

The ad placeholder from the Google Publisher Console are not deleted when the component is unmounted

Open getkey opened this issue 8 years ago • 2 comments

When the Google Publisher Console is open on a page with ads, if the Bling get unmounted the yellow ad placeholder stays displayed. screenshot from 2017-07-26 16-15-32

The ad seems to be properly removed though because it does not appear in the bottom panel of the Google Console. :-)

getkey avatar Jul 26 '17 14:07 getkey

My guess is GPC is not rendered inside Bling. You could query select and remove the GPC DOM wrapper or call some GPC destroy method... Id execute it only if I found the feature flag for ?goog_fc or whatever the flag is to turn it on.

potench avatar Jul 29 '17 07:07 potench

That should be pretty straight forward if you figure out the wrapping div or if the console comes with an API to destroy itself. PR it!

potench avatar Jul 29 '17 07:07 potench