tools icon indicating copy to clipboard operation
tools copied to clipboard

Add charliecloud.registry

Open nschan opened this issue 1 year ago • 3 comments

As of 24.03.0-edge nextflow's charliecloud driver has gained support for registry. This PR adds quay.io as the default registry for charliecloud.

nschan avatar Apr 26 '24 10:04 nschan

This PR is against the master branch :x:

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @nschan,

It looks like this pull-request is has been made against the nf-core/tools master branch. The master branch on nf-core repositories should always contain code from the latest release. Because of this, PRs to master are only allowed if they come from the nf-core/tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page. Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

github-actions[bot] avatar Apr 26 '24 10:04 github-actions[bot]

That is a fair point, however charliecloud in nf-core is currently broken irrespective of these changes. I think adding this now and providing a config for people who want to use the edge release will not hurt, even if the default will only be updated with the next proper release?

nschan avatar Apr 26 '24 14:04 nschan

Thanks for approving, charliecloud.registry is actually still broken in 24.03.0-edge. I figured out how it is done now, see here https://github.com/nextflow-io/nextflow/pull/5018

nschan avatar May 23 '24 12:05 nschan

@maxulysse can you approve it as well? then it can be merged when the nextflow version gets bumped to 24.04. Have been using this config with the edge release without issues (thanks @nschan).

lrauschning avatar May 23 '24 12:05 lrauschning

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.11%. Comparing base (4ebbbb0) to head (b81e98c).

Additional details and impacted files

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 23 '24 12:05 codecov[bot]