tools icon indicating copy to clipboard operation
tools copied to clipboard

Handling with patched modules in subworkflows

Open mirpedrol opened this issue 3 years ago • 1 comments

Description of feature

As discussing with @mashehu during the nf-core hackathon, we need to deal with patched modules used in subworkflows.

TODOs:

  • [ ] When installing a subworkflow with nf-core subworkflows install if there's a module needed in the subworkflow and already installed, it asks the user to force re-install the module. Currently, it deletes the module folder and installs it fresh. We need to check if that module has a patch file to save it and apply after the installation.
  • [ ] When a module is patched, throw a warning telling the user that this might break the subworkflow.
  • [ ] When a module is patched, offer the option to run tests. Pull tests from the nf-core/modules repo if it's available and run them.

mirpedrol avatar Oct 11 '22 08:10 mirpedrol

Is patched modules - subworkflows interplay/interaction another reason to promote/investigate having subworkflows operate more like standalone workflows which package their own modules/subworkflows as discussed here (I know I push this a lot sorry, I will continue to until someone shouts at me not to 😂)

awgymer avatar Mar 18 '24 10:03 awgymer