slack-bundle icon indicating copy to clipboard operation
slack-bundle copied to clipboard

Suggestion - more unit test freindly

Open ksteinmetz opened this issue 7 years ago • 1 comments

Hi, I happened on this great implementation while trying to get our code to talk to slack. We had most of the basics in our own code, so this made sense.

While trying to unit test our code interface, I found phpunit can not mock your \Nexy\Slack\Client and \Nexy\Slack\Message classes, because they are marked Final.

It would be great if there was a simple interface that the Client and Message could implement so that your code can remain final and it is easy to mock your client and message classes through the interface. Then your code would be even more friendly.

Thanks and keep up the great work

ksteinmetz avatar Oct 05 '18 23:10 ksteinmetz

Hi @ksteinmetz and sorry for the long time for answer.

I like the idea, would you like to do it?

soullivaneuh avatar Feb 20 '19 10:02 soullivaneuh