nextui icon indicating copy to clipboard operation
nextui copied to clipboard

unit test coverage udpate

Open sun0day opened this issue 3 years ago • 3 comments

📝 Description

This is a long-term branch. All PRs from this branch intend to increase UT coverage and optimize nextui source code. I will continuously commit test code to this branch.

All commits in this branch are atomic, feel free to merge PR at any time. @jrgarciadev

💣 Is this a breaking change (Yes/No):

No

Updated UT Coverage

  • use-pagination: statements 100% ⬆️ , branches 100% ⬆️

sun0day avatar Sep 07 '22 09:09 sun0day

@sun0day is attempting to deploy a commit to the NextUI Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Sep 07 '22 09:09 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nextui-storybook ✅ Ready (Inspect) Visit Preview Sep 7, 2022 at 2:52PM (UTC)

vercel[bot] avatar Sep 07 '22 09:09 vercel[bot]

Should not change activePage via calling setActivePage when page is set to specific number.

https://github.com/nextui-org/nextui/blob/50f8f9dbcb1db177f125a1f144c346e3ec3fc29e/packages/react/src/use-pagination/index.ts#L28-L31

sun0day avatar Sep 07 '22 09:09 sun0day