fix(popover): arrow combine with border of box

[arindam1997007]

Closes #3235

📝 Description

Popover arrow combines with that of the box's content.

⛳️ Current behavior (updates)

Arrow is with negative zIndex, being put behind the content box.

🚀 New behavior

Arrow is in same zIndex, and the rest of the arrow is clipped using clip-path.

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

This changes also affects the same look for the arrow, for Tooltip component, since both of these component uses the same design.

📸 Output

Summary by CodeRabbit

• Bug Fixes
  • Improved positioning and styling of popover elements for better visual presentation.
  • Fixed issue with popover arrow alignment with the border.

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: b5c0a41fecfcf2ae0a174e809fc1462d5de7de74

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@nextui-org/theme	Patch
@nextui-org/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nextui-storybook-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 25, 2024 0:21am

[vercel[bot]]

@arindam1997007 is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai[bot]]

Walkthrough

The changes primarily address the visual integration of popover elements by refining their positioning and styling, adding utilities for clip-path handling, and ensuring the popover arrow seamlessly combines with the border of the box. Adjustments include space recalculations and clip-path styles for better presentation.

Changes

Files	Change Summary
.../components/popover.ts	Removed "before:z-[-1]", updated positioning calculations, and added clip-path styles for popover elements.
.../utilities/clip-path.ts	Added utilities defining clip-path CSS properties for different popover positions (top, bottom, left, right).
.../utilities/index.ts	Added import clipPath and included clipPath utility in the utilities object.
.changeset/flat-insects-heal.md	Introduced a patch for @nextui-org/theme to fix the popover arrow combining issue with the border of the box.

Sequence Diagram(s)

The changes do not modify or introduce new control flows significantly enough to warrant sequence diagrams.

Assessment against linked issues

Objective	Addressed	Explanation
Popover's arrow should combine with the border line of the box (#3235)	✅

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[arindam1997007]

Thanks for the PR.

Since you've modified something inside packages, therefore you need to add a changeset

@wingkwong Changeset is added now.

[wingkwong]

After an internal discussion, we’ve decided not to move forward with integrating this pull request and keep the original design as it is. Please do not be discouraged. We hope this decision will not deter you from continuing to contribute in the future. Thank you once again for your understanding and your interest in contributing to us.