migrations icon indicating copy to clipboard operation
migrations copied to clipboard

Added resetCommand config

Open slischka opened this issue 7 years ago • 4 comments

#84 BC break:

  • yes, you need enable in cofig to register reset command

missing:

  • Updated doc
  • Test where reset command is not registred

slischka avatar Jul 29 '18 13:07 slischka

I'm against this change. The default configurator is fine as is. If you need different set of commands, you should register them into the symfony console app manually instead.

Mikulas avatar Jul 30 '18 07:07 Mikulas

It's about to disable reset command on production environment. Yeah, there are a lot of way to delete production database. But I do not even want this comman enabled on production enviroment so i can not accidentally delete production DB via terminal/console. The are other ways like you can disable or protect to not delete DB, like user permission. But some times you cannot set this think. We can do it the other way, always enabled, but have a choise to disabled it.

And yes, I can setup this manualy. But why when i can just use configuration.

slischka avatar Jul 30 '18 11:07 slischka

I personally like this change, but I'm not sure it should "not register" command.

Wouldn't it be better to just from exception from "reset" command, expaining that reset has been disabled due to current configuration?

jkuchar avatar Jan 28 '21 11:01 jkuchar

I also like this change, especially the idea behind it – you never want to accidentally erase your database just because you mistyped or applied your habit from local development before you realize what you are doing. I don't mind the form pretty much – personally I just need to block me when I'm too quick – maybe the exception is fine.

dakur avatar Jan 28 '21 11:01 dakur