funannotate icon indicating copy to clipboard operation
funannotate copied to clipboard

Allow runSubprocess to raise error instead of exiting

Open mglubber opened this issue 3 years ago • 1 comments

Fix for issue #784 Allow runSubprocess to raise an error instead of running sys.exit(1) by setting raise_not_exit=True. This can prevent the program from hanging if a subprocess has an error while being run as part of a multi-processing pool. Remove the redundant function runMultiNoProgress, which can be handled by using runMultiProgress with progress=False. Switch iprscan-local.py to use runMultiProgress from funannotate.library, instead of a redundant local copy of the function.

I think using runSubprocess with raise_not_exit=True can be used to replace a bunch of the safe_run functions in some of the auxiliary scripts, but I haven't had a chance to try that yet.

mglubber avatar Sep 14 '22 19:09 mglubber

Great, thanks for the help/contribution. Looks like you are perhaps still updating a few things -- let me know when you are happy with the changes :)

nextgenusfs avatar Sep 14 '22 20:09 nextgenusfs

are there additional changes @mglubber you were making or are these updates stable?

hyphaltip avatar Oct 18 '22 22:10 hyphaltip