viewer icon indicating copy to clipboard operation
viewer copied to clipboard

[BUG] Media not showing in preview in File App

Open themitichris opened this issue 1 year ago • 3 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Current Behavior

After doing upgrade I cannot see preview in File App. In console I see this error Viewer.vue:639 Could not open file /path/to/file.jpg TypeError: Cannot destructure property 'filename' of 'e' as it is undefined. at G (fileUtils.ts:88:23) at new K (file.js:35:12) at o.openFileInfo (Viewer.vue:725:1) at async o.openFile (Viewer.vue:631:1)

image image

Expected Behavior

No response

Steps To Reproduce

Upgrade from 27 to 28.0.2 (latest) Open a file from the App Files

Environment

- OS: Unraid

Container logs

[migrations] started
[migrations] 01-nginx-site-confs-default: skipped
[migrations] 02-default-location: skipped
[migrations] done
usermod: no changes
───────────────────────────────────────
      ██╗     ███████╗██╗ ██████╗
      ██║     ██╔════╝██║██╔═══██╗
      ██║     ███████╗██║██║   ██║
      ██║     ╚════██║██║██║   ██║
      ███████╗███████║██║╚██████╔╝
      ╚══════╝╚══════╝╚═╝ ╚═════╝
   Brought to you by linuxserver.io
───────────────────────────────────────
To support LSIO projects visit:
https://www.linuxserver.io/donate/
───────────────────────────────────────
GID/UID
───────────────────────────────────────
User UID:    911
User GID:    911
───────────────────────────────────────
using keys found in /config/keys
**** The following active confs have different version dates than the samples that are shipped. ****
**** This may be due to user customization or an update to the samples. ****
**** You should compare the following files to the samples in the same folder and update them. ****
**** Use the link at the top of the file to view the changelog. ****
┌────────────┬────────────┬────────────────────────────────────────────────────────────────────────┐
│  old date  │  new date  │ path                                                                   │
├────────────┼────────────┼────────────────────────────────────────────────────────────────────────┤
│ 2022-08-16 │ 2023-04-13 │ /config/nginx/nginx.conf                                               │
│ 2022-08-20 │ 2023-08-13 │ /config/nginx/ssl.conf                                                 │
│ 2022-08-20 │ 2024-01-03 │ /config/nginx/site-confs/default.conf                                  │
└────────────┴────────────┴────────────────────────────────────────────────────────────────────────┘
[custom-init] No custom files found, skipping...
[ls.io-init] done.

themitichris avatar Feb 17 '24 17:02 themitichris

@artonge also related to the live photo https://github.com/nextcloud/viewer/blob/0bb040910137080c654c944810e1b9bde3008896/src/utils/fileUtils.ts#L120

skjnldsv avatar Feb 20 '24 09:02 skjnldsv

I have similar problem in when trying to view files in shared via url folder. In the browser console I get:

FileInfo.ts:40 
       PROPFIND https://xxx/public.php/webdav/IMG_20240222_121013.jpg 401 (Unauthorized)
(anonymous) @ index.js:2
value @ index.js:2
value @ index.js:2
(anonymous) @ index.js:2
(anonymous) @ index.js:2
value @ index.js:2
value @ index.js:2
le @ index.js:2
ue @ index.js:2
ce @ index.js:2
(anonymous) @ index.js:2
n @ index.js:2
stat @ index.js:2
oe @ FileInfo.ts:40
request @ CancelableRequest.js:41
openFile @ Viewer.vue:630
file @ Viewer.vue:466
cn @ vue.runtime.esm.js:3017
e.run @ vue.runtime.esm.js:3534
er @ vue.runtime.esm.js:4125
(anonymous) @ vue.runtime.esm.js:3143
An @ vue.runtime.esm.js:3065
Promise.then (async)
pn @ vue.runtime.esm.js:3090
yn @ vue.runtime.esm.js:3155
tr @ vue.runtime.esm.js:4211
e.update @ vue.runtime.esm.js:3513
e.notify @ vue.runtime.esm.js:720
set @ vue.runtime.esm.js:963
open @ Viewer.js:302
te @ LegacyFilesActionHandler.js:40
action @ fileactions.js?v=442ffbc5-1:136
_onClickFile @ filelist.js?v=442ffbc5-1:915
Ce @ _executeBound.js:8
(anonymous) @ bind.js:10
(anonymous) @ restArguments.js:16
dispatch @ jquery.js:5145
g.handle @ jquery.js:4949


Viewer.vue:639 Could not open file /IMG_20240222_121013.jpg Error: Invalid response: 401 
    at pt (index.js:2:93546)
    at ft (index.js:2:93807)
    at index.js:2:98785
    at async oe (FileInfo.ts:40:11)
    at async o.openFile (Viewer.vue:630:1)

Preview in the same folder when logged in works fine. Please let me know if I should open a new defect for this.

lucaluse avatar Feb 26 '24 19:02 lucaluse

I have the same problem here. External storage via webdav

rudnypc avatar May 14 '24 00:05 rudnypc

Bildschirmfoto vom 2024-07-29 08-06-36

I'm experiencing this inside Talk. A never ending loading spinner shows. Stack indicates live photo too after the actual picture's file info was successfully loaded. Closing Viewer and opening the image a second time makes it load almost instantly.

ChristophWurst avatar Jul 29 '24 06:07 ChristophWurst

Closing Viewer and opening the image a second time makes it load almost instantly.

so weird :thinking:

skjnldsv avatar Jul 30 '24 06:07 skjnldsv

Feel free to reopen if it reoccurs, I am not 100% sure of the fix

artonge avatar Aug 28 '24 19:08 artonge