smb login improperly escapes username

[stefanfritsch]

Affected apps

This afflicts the smb login backend of user_external. It also applies to external storage so I'm not sure where to post this.

Expected behaviour

Use the Samba user "[email protected]" to login to NextCloud.

Actual behaviour

Login fails because the username is improperly escaped (I assume) and so the "@" causes it to fail. The login works fine with the (separately added) user "myuser."

Steps to reproduce

1. Set up Samba
2. smbpasswd -a "[email protected]", smbpasswd -a "myuser"
3. Set password
4. Try login from connected NextCloud. "myuser" works, "[email protected]" doesn't.

Server configuration

NGINX: nginx/1.10.3

PHP Version: 7.1.2 Memory Limit: 512.0 MB Max Execution Time: 10800 Upload max size: 10.0 GB

Database Type: mysql Version: 10.1.21 Size:

NextCloud version: 11.0.2.7

Logs

Web server error log

Nothing - though that might be down to container settings

ownCloud log (data/owncloud.log)

{"reqId":"t13LpmruSZpw0FvUqaQ1","remoteAddr":"192.168.3.87","app":"core","message":"Login failed: '[email protected]' (Remote IP: '192.168.3.87')","level":2,"time":"2017-03-13 12:25:26","method":"POST","url":"\/login?user=myuser%40something.com","user":"--","ver
sion":"11.0.2.7"}

[violoncelloCH]

possibly related to #16?