terms_of_service icon indicating copy to clipboard operation
terms_of_service copied to clipboard
verified publisher icon nextcloud

Draft: Refactor and add nextcloud coding standards

Open akhil1508 opened this issue 2 years ago • 3 comments

  • Remove vendor folder from repository
  • Add step to do composer install in Makefile
  • Add .php-cs-fixer.dist.php file
  • Used https://github.com/nextcloud/contacts/blob/main/composer.json and https://github.com/nextcloud/contacts/blob/main/.php-cs-fixer.dist.php for reference

akhil1508 avatar Mar 20 '23 10:03 akhil1508

Actually looks like https://github.com/nextcloud/terms_of_service/pull/788/ is already open and resolving these issues. Is it blocked for some reason @nickvergessen ?

akhil1508 avatar Mar 20 '23 10:03 akhil1508

Just lack of time and success on the PR.

nickvergessen avatar Mar 20 '23 10:03 nickvergessen

https://github.com/nextcloud/terms_of_service/pull/1004 introduced vendor-bin So it should be much easier going forward

nickvergessen avatar Oct 23 '24 09:10 nickvergessen