talk-desktop icon indicating copy to clipboard operation
talk-desktop copied to clipboard

Notifications: add badge dot to the system tray icon when there is a new or unread message.

Open ShGKme opened this issue 2 years ago • 16 comments

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.

There is a notification about a new message and taskbar icon badge. But when the window is closed and the notification is closed, it is not visible that some notification is missed.

Describe the solution you'd like

Add a badge dot to the tray system tray icon when there is a new or unread message.

Describe alternatives you've considered

Currently, we have a badge about a new notification similar to * in the title on web-client. But it could be more useful to have a badge about unread mentions.

The difference is that the current badge appears only on a notification and disappears on window/tab activating. While usually such badges are shown when there are any unread mentions, no matter if the window is open or it is an old message.

Additional context

Discord example:

image

ShGKme avatar Aug 11 '23 07:08 ShGKme

There is a notification about a new message and taskbar icon badge.

I don't see this working at the moment in the Task Bar? Installed version from a few days ago.

Example, I have unread messages in Talk but no badge in the taskbar, compared to Discord and Mattermost.

image

ecker00 avatar Oct 09 '23 11:10 ecker00

Same issue in macOS 12.6. Would also love to see message count Bildschirmfoto 2023-11-01 um 11 30 29 Bildschirmfoto 2023-11-01 um 11 30 38

benjamindahl avatar Nov 01 '23 10:11 benjamindahl

It seems all the pieces are already in place to fix this. In my dev machine I could easily get it to work by moving this setBadgeCount line in notifications.store.js:

// If we didn't already highlight, store the title so we can restore on tab-view
if (!document.title.startsWith('* ')) {
	window.TALK_DESKTOP.setBadgeCount()
	document.title = '* ' + document.title
}

to

// If we didn't already highlight, store the title so we can restore on tab-view
window.TALK_DESKTOP.setBadgeCount()
if (!document.title.startsWith('* ')) {
	document.title = '* ' + document.title
}

But I'm new to nextcloud so not sure I tested it thoroughly enough to know if this would break something. If any of the devs could confirm this might be safe I can do a pull-request.

xataxxx avatar Apr 22 '24 07:04 xataxxx

@xataxxx the original issue is a bit more complex. It is about showing a permanent marker depending on the number of all unread chats/mentions.

This badge is only used to notify the user about new notifications when the window is minimized (to the taskbar, not to the system tray).

Besides, I don't see what this proposal changes. The badge and the * Title are always set and reset together. Do you know a scenario where the title doesn't start with * Title but there should be a badge? If yes, then it should be fixed in place with incorrect title change as well.

ShGKme avatar Apr 23 '24 13:04 ShGKme

This badge is only used to notify the user about new notifications when the window is minimized (to the taskbar, not to the system tray).

The badge seems to be not working on Win 11 at the moment. I could not see any change on the taskbar icon when a new message arrives while app is minimized to taskbar.

New message do not arrive immediately, they are not loaded until the windows comes back to focus (click on symbol in taskbar). Windows Notifications about new msg are also shown delayed.

Maybe this has to do with Talk Version 18.0.4 on the server side, Desk client is 0.29?

fitus85 avatar Apr 23 '24 15:04 fitus85

The badge seems to be not working on Win 11 at the moment. I could not see any change on the taskbar icon when a new message arrives while app is minimized to taskbar.

New message do not arrive immediately, they are not loaded until the windows comes back to focus (click on symbol in taskbar). Windows Notifications about new msg are also shown delayed.

Works for me, both badge and native notification except known Talk notifications limitation.

But anyway, this is not about this issue.

ShGKme avatar Apr 23 '24 15:04 ShGKme

@xataxxx Actually, you were right. I've found this case when there is a race condition with Talk itself that also changed document title with * , which results in skipping flashing.

Thanks!

ShGKme avatar May 02 '24 17:05 ShGKme

I can only see the dot in task bar instead of system tray in the latest release 0.31.0

ER-EPR avatar Jul 05 '24 04:07 ER-EPR

The desktop app has now been officially released and we would like to use it in our company. But unfortunately it is not yet possible without this feature.

manswiss avatar Dec 03 '24 16:12 manswiss

Dot badge is available for a while.

Number of the messages is covered by another issue.

ShGKme avatar Dec 03 '24 16:12 ShGKme

Dot badge is available for a while.

Number of the messages is covered by another issue.

Thanks for your reply. When I close the application, then it is minimized to the systemtray. When somebody write me a message, I see no dot or other message. I get only a audio notification. On the mobile app on android is all perfect, but not in the windows app.

manswiss avatar Dec 03 '24 16:12 manswiss

It is also my most needed feature. Show some changes in system tray icon.

ER-EPR avatar Dec 04 '24 00:12 ER-EPR

Dot badge is available for a while. Number of the messages is covered by another issue.

Thanks for your reply. When I close the application, then it is minimized to the systemtray. When somebody write me a message, I see no dot or other message. I get only a audio notification. On the mobile app on android is all perfect, but not in the windows app.

I think @ShGKme means that this issue covers a dot on the task bar icon, and there are other issues for the systray icon: #85 and #391

RTechSn avatar Dec 04 '24 09:12 RTechSn