🚫 Allow Banning Users and Guests
- fixes #3898
Screenshots
ToDo
- [x] Add Capabilities and Moderator Check
- [x] Model
- [x] Api See overview routes
- [x] ViewModel
- [x] View
- [x] Ban button - for each participant in list. Show dialog for an internal Note.
- [x] "List Bans" Button should trigger a scrollable full screen dialog showing all the Bans. Display Internal Note if needed.
- [x] XML
- [x] Fragment class
- [x] Unban button, should be present as an option on every list item (Need to check if successful)
- [x] The UI is atrocious, need to make it look good
- [ ] Need to implement it with Guests too
Bugs
- [x] Drop down color needs to be constantly, nc_grey
🏁 Checklist
- [ ] ⛑️ Tests (unit and/or integration) are included or not needed
- [ ] 🔖 Capability is checked or not needed
- [ ] 🔙 Backport requests are created or not needed:
/backport to stable-xx.x - [ ] 📅 Milestone is set
- [x] 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)
Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.
We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.
Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6
Thank you for contributing to Nextcloud and we hope to hear from you soon!
rebased on master and tested (not sure which things may not work because server is not ready yet..).
-
When i ban some user, he is still shown in the participants list (same on web).
-
He is also shown in the bans list. "Unban" seems to do nothing, after clicking he is still shown in the bans list. (for web, unban seems to work).
-
Actual banning does not work, the user can still write..
-
Date is always x.x.1970
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3904-talk.apk
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.