spreed
spreed copied to clipboard
Refactor: Move common message related computed props into composable
☑️ Resolves
- Fix condition in
NewMessageso it filters messages withing 24 hours (according to the current editing capability) - Move
isEditablelogic to composable. - Move more common computed props
- There were missing oneToOne props in some components O.o
🏁 Checklist
- [ ] 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
- [ ] 🖥️ Tested with Desktop client or should not be risky for it
- [ ] 🖌️ Design was reviewed, approved or inspired by the design team
- [ ] ⛑️ Tests are included or not possible
- [ ] 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required
I thought about it as a bigger thing, like useConversationInfo for several things at once.
Now you compute several things twice for MessageButtonsBar (isMyMsg, isConversationReadOnly and so on)
I think we could extract to composable and return from it more than isEditable only
/backport to stable29