server icon indicating copy to clipboard operation
server copied to clipboard

When hovering over an avatar, do not only display local time but also calculate the time difference compared to you (similar to how GitHub does this)

Open sorbaugh opened this issue 1 year ago • 3 comments

Subtask: #43763

sorbaugh avatar Oct 09 '24 11:10 sorbaugh

cc @nickvergessen something that is relevant for Talk too?

sorbaugh avatar Oct 09 '24 11:10 sorbaugh

Will automatically appear in Talk if modified correctly in the LocalTimeProvider

nickvergessen avatar Oct 09 '24 12:10 nickvergessen

Notes:

  • Might need backend work. Judging from nickvergessen's comment this would require "only" a change in one line of code but needs to be tested.
  • We need to improve the user popup a bit. There's additional data that could be added. Consensus is generally the user popup could use some love.

sorbaugh avatar Oct 10 '24 10:10 sorbaugh

@marcoambrosini our assumption would be something like displaying "Local time: 9:41 AM (3 hours behind)", "Local time: 9:41 AM (2 hours ahead)"

We're not sure yet. Wdyt?

Image

sorbaugh avatar Dec 02 '24 08:12 sorbaugh

I think that works, and we should put that in a new line

marcoambrosini avatar Dec 02 '24 09:12 marcoambrosini

I think that works, and we should put that in a new line

cc @yemkareems

sorbaugh avatar Dec 02 '24 10:12 sorbaugh

Question: Is the "Local time:" part required? Github only uses the icon + local time + offset like:

🕐 15:24 - 9h30m ahead

This would fit into one line without breaking the layout

susnux avatar Jan 16 '25 09:01 susnux

If we prefer to keep it we maybe should think about allowing the API to pass a second line so we end up with:

🕐 Local time: 15:24
   3 hours ahead

(or if 12h format was chosen)

🕐 Local time: 9:30 AM
   2 hours behind

susnux avatar Jan 16 '25 10:01 susnux