server icon indicating copy to clipboard operation
server copied to clipboard

Add mimetype for ReStructuredText

Open kyteinsky opened this issue 2 years ago • 4 comments

Summary

Mimetype for re structured text. It is aliased to text.
There is no official mimetype for .rst files so text/plain can also work here.

Checklist

kyteinsky avatar Nov 23 '23 11:11 kyteinsky

If you want to update the mime type for files already existing in oc_filecache an additional change for lib/private/Repair/RepairMimeTypes.php is necessary.

Example: https://github.com/nextcloud/server/pull/41395/files#diff-f89544ac76d4f0e2cd70b4979d625b3992a72fa26c6f0b5fe92ec0364b9716e9

kesselb avatar Nov 23 '23 17:11 kesselb

I had assumed repair was a file preview thing. Added it now, thanks for the explanation.
Do the changes in tests/data/integritycheck/mimetypeListModified/core/js/mimetypelist.js also need to be pushed?

kyteinsky avatar Nov 30 '23 10:11 kyteinsky

I had assumed repair was a file preview thing. Added it now, thanks for the explanation. Do the changes in tests/data/integritycheck/mimetypeListModified/core/js/mimetypelist.js also need to be pushed?

Yep.

There should be a brief inline description in CheckerTest how to update it properly.

kesselb avatar Nov 30 '23 14:11 kesselb

The CheckerTest did not update the core/js/mimetypelist.js file, which was updated with ./occ maintenance:mimetype:update-js as mentioned in the file.

kyteinsky avatar Nov 30 '23 15:11 kyteinsky

Possible performance regression detected

Show Output
564 queries added

= /remote.php/dav/files/test
= /remote.php/dav/files/test/test.txt
= /remote.php/dav/files/test/many_files
= /remote.php/dav/files/test/new_file.txt
= /remote.php/dav/files/test/new_file.txt
= /remote.php/dav/files/test
= /remote.php/dav/files/test/test.txt
= /remote.php/dav/files/test/many_files
= /remote.php/dav/files/test/new_file.txt
= /remote.php/dav/files/test/new_file.txt
+ /remote.php/dav/files/test added with 45 queries
+ /remote.php/dav/files/test/test.txt added with 33 queries
+ /remote.php/dav/files/test/many_files added with 46 queries
+ /remote.php/dav/files/test/new_file.txt added with 67 queries
+ /remote.php/dav/files/test/new_file.txt added with 91 queries
+ /remote.php/dav/files/test added with 45 queries
+ /remote.php/dav/files/test/test.txt added with 33 queries
+ /remote.php/dav/files/test/many_files added with 46 queries
+ /remote.php/dav/files/test/new_file.txt added with 67 queries
+ /remote.php/dav/files/test/new_file.txt added with 91 queries

github-actions[bot] avatar Feb 23 '24 19:02 github-actions[bot]

Conflicts @kyteinsky

skjnldsv avatar Mar 15 '24 14:03 skjnldsv