server icon indicating copy to clipboard operation
server copied to clipboard

`Limit to groups` selection broken for >~5 groups

Open q-wertz opened this issue 2 years ago • 3 comments

⚠️ This issue respects the following points: ⚠️

Bug description

In the Admin Apps menu, the Limit to groups selector (and list of allowed groups) is broken/very inconvenient.

  • If there are more groups than fit into the one line sidebar, the bar is extended horizontally to the right (which makes it unreadable)
  • The selectbox cannot be scrolled only searched -> one can only search for the group names by typing in the beginning of the group name -> the groups that are not in the top 5 cannot be removed conveniently (one again has to search for the name)

Steps to reproduce

  1. Go to the Apps menu
  2. Select an App
  3. (Try) to add a few groups
  4. Extra: Try to remove groups that are not in the default list of 5

Expected behavior

  1. The field gets a multiline view as soon as the group names exceed the available horizontal space
  2. The selectbox for adding other groups is scrollable
  3. To be able to remove groups, it would be also convenient to list the enabled groups at the top.

Installation method

Community Manual installation with Archive

Nextcloud Server version

26

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Nginx

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • [X] Default user-backend (database)
  • [X] LDAP/ Active Directory
  • [ ] SSO - SAML
  • [ ] Other

Configuration report

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "nc.asdf.de",
            "nc.asdf1.de"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "26.0.3.2",
        "overwrite.cli.url": "https:\/\/nc.asdf.de",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "mysql.utf8mb4": true,
        "maintenance": false,
        "session_lifetime": 604800,
        "session_keepalive": true,
        "mail_smtpmode": "smtp",
        "mail_sendmailmode": "smtp",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "25",
        "default_language": "de_DE",
        "default_locale": "de",
        "default_phone_region": "DE",
        "skeletondirectory": "",
        "loglevel": 2,
        "updater.release.channel": "stable",
        "app_install_overwrite": [
            "drawio"
        ],
        "mail_smtpsecure": "tls",
        "ldapIgnoreNamingRules": false,
        "ldapProviderFactory": "OCA\\User_LDAP\\LDAPProviderFactory",
        "lost_password_link": "disabled",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 0,
            "password": "***REMOVED SENSITIVE VALUE***"
        },
        "activity_use_cached_mountpoints": false
    }
}

List of activated Apps

No response

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

No response

Additional info

Firefox: 115.0.1

q-wertz avatar Jul 11 '23 15:07 q-wertz

You should add screenshots to make the issue more clear. 👍

solracsf avatar Jul 12 '23 08:07 solracsf

group_selection2

00:00-00:08: Overflowing 00:08-00:11: Missing scrolling 00:13-end: (Inconventient) way to add/remove a group that is not in the default list

q-wertz avatar Jul 12 '23 11:07 q-wertz

The issue consists of two independent bugs:

  1. A layout problem - drop-down list is hidden below app description:

    image Haven't found a simple workaround yet. It is possible to remove the app description using browsers "inspect" function; then the drop-down will be shown correctly.

  2. A maximum of five groups are populated into the selection list / input field.

Source of the second problem is an explicit limitation to 5 groups in settings-apps-view-7418.js.

The following workaround solves the problem in a live system:

sed -i -re 's/:5([,}])/:99\1/g' dist/settings-apps-view-7418.js

profhccaesar avatar Feb 01 '24 15:02 profhccaesar