server icon indicating copy to clipboard operation
server copied to clipboard

fix(s3): Pass SSE-C parameters for multipart upload

Open juliusknorr opened this issue 2 years ago • 1 comments

Follow up fix for #27034 to make it work properly with SSE-C encryption enabled.

juliusknorr avatar Jun 21 '23 16:06 juliusknorr

/backport to stable27

juliusknorr avatar Jun 21 '23 16:06 juliusknorr

This is a hot feature to combine with Verified Credentials ...

tsdicloud avatar Jul 18 '23 15:07 tsdicloud

@juliushaertl thank you for adding SSE-C support to the new S3 MultipartUpload feature, really appreciate your work here. After review the changes, i think you also need to add SSE-C headers to the headObject call on line 99: https://github.com/nextcloud/server/blob/f824d87fc1f3aa99ddb141b7ba19b48641d2cb84/lib/private/Files/ObjectStore/S3.php#L99

Reference: https://docs.aws.amazon.com/AmazonS3/latest/API/API_HeadObject.html

ir0nhide avatar Jul 25 '23 21:07 ir0nhide