server icon indicating copy to clipboard operation
server copied to clipboard

Adjust saving of status messages

Open Antreesy opened this issue 2 years ago • 1 comments

  • Resolves: #38817 (both mentioned issues)

Summary

  • When we select predefined status, it updates and goes to server automatically. Now, we don't update it on 'Set satus', as it's already there.
  • Instead, we check if message was modified (become Custom), and if true, send a custom status to server
  • Also, previously we sent signal on every input @change (that means blurring the input after modifying, pressing Enter to submit and so on). Now, we left only @keyup.enter to immediately submit status, so if we change message to predefined, we don't send last custom message to server
  • In addition, store was modified, so getter is reactive now

TODO

  • [ ] Visual and behavior check

Checklist

Antreesy avatar Jun 15 '23 10:06 Antreesy

Sorry. I know too little about status to understand/review the changes.

ChristophWurst avatar Jun 15 '23 15:06 ChristophWurst

Wrapped all components with native form, and rebased onto master Should be tested how it will work with some input methods (Chinese/Japanese/e.t.c)

Antreesy avatar Jun 26 '23 11:06 Antreesy

Seems to work: Bildschirmaufzeichnung vom 2023-06-26, 13-54-24.webm

nickvergessen avatar Jun 26 '23 11:06 nickvergessen

Rebased onto master and replace three listeners with @input listener only, now we're watching after every input.value change, but submit only on Enter or button click

Tested, seems to work on Linux, but we need to check that for some languages (Chinese, e.t.c) on Windows and MacOS cc @ShGKme @SystemKeeper

Antreesy avatar Jun 28 '23 13:06 Antreesy

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

welcome[bot] avatar Jun 28 '23 17:06 welcome[bot]

/backport to stable27

szaimen avatar Jun 28 '23 18:06 szaimen

/backport to stable27

szaimen avatar Jun 28 '23 18:06 szaimen

Backport with compiled JS never works. especially when the node version differs

nickvergessen avatar Jun 29 '23 07:06 nickvergessen