Adjust saving of status messages
- Resolves: #38817 (both mentioned issues)
Summary
- When we select predefined status, it updates and goes to server automatically. Now, we don't update it on 'Set satus', as it's already there.
- Instead, we check if message was modified (become Custom), and if true, send a custom status to server
- Also, previously we sent signal on every input
@change(that means blurring the input after modifying, pressing Enter to submit and so on). Now, we left only@keyup.enterto immediately submit status, so if we change message to predefined, we don't send last custom message to server - In addition, store was modified, so getter is reactive now
TODO
- [ ] Visual and behavior check
Checklist
- Code is properly formatted
- Sign-off message is added to all commits
- [ ] Tests (unit, integration, api and/or acceptance) are included
- [x] Screenshots before/after for front-end changes - no visual changes
- [x] Documentation (manuals or wiki) has been updated or is not required
- [ ] Backports requested where applicable (ex: critical bugfixes)
Sorry. I know too little about status to understand/review the changes.
Wrapped all components with native form, and rebased onto master Should be tested how it will work with some input methods (Chinese/Japanese/e.t.c)
Seems to work:
Rebased onto master and replace three listeners with @input listener only, now we're watching after every input.value change, but submit only on Enter or button click
Tested, seems to work on Linux, but we need to check that for some languages (Chinese, e.t.c) on Windows and MacOS cc @ShGKme @SystemKeeper
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
/backport to stable27
/backport to stable27
Backport with compiled JS never works. especially when the node version differs