Detect weird local ips

[come-nc]

Use new dependency to detect weird syntaxes

• [x] https://github.com/nextcloud/3rdparty/pull/1173
• [x] rebase

[kesselb]

Thanks for taking care :+1:

In theory we can drop the iputils (symfony http-foundation) again and only use the ip-lib package: https://github.com/mlocati/ip-lib#check-if-an-address-is-contained-in-a-range

This could also help with https://github.com/nextcloud/server/issues/33567

[come-nc]

Thanks for taking care +1

In theory we can drop the iputils (symfony http-foundation) again and only use the ip-lib package: https://github.com/mlocati/ip-lib#check-if-an-address-is-contained-in-a-range

This could also help with #33567

Hum but I trust the range detection in symfony more, especially it correctly tests ipv6 in ipv4 ranges, which ip-lib does not. But as our code translates the IP to v4 if it maps, maybe it is not a problem.

[kesselb]

Thanks for taking care +1 In theory we can drop the iputils (symfony http-foundation) again and only use the ip-lib package: https://github.com/mlocati/ip-lib#check-if-an-address-is-contained-in-a-range This could also help with #33567

Hum but I trust the range detection in symfony more, especially it correctly tests ipv6 in ipv4 ranges, which ip-lib does not. But as our code translates the IP to v4 if it maps, maybe it is not a problem.

Good point :+1:

[come-nc]

@kesselb I can make a PR to use ip-lib instead of iputils but I’d like to do so in a separate PR once this one is merged.

[nickvergessen]

3rdparty merged

[kesselb]

@kesselb I can make a PR to use ip-lib instead of iputils but I’d like to do so in a separate PR once this one is merged.

Sorry I was just thinking loud. The current way is fine and we can combine both libraries.

[come-nc]

/backport to stable24

[come-nc]

/backport to stable23

[nickvergessen]

/backport to stable22

[PVince81]

/backport to stable25

[blizzz]

/backport to stable25