server Fix update when viewer is not installed

Since the viewer app is not shipped with server, currently with a fresh clone of the server repo it is impossible to do an update.

Aug 04 '22 08:08 CarlSchwan

should we limit the check disablement for git clones ? this can be detected by checking if versions.php contains "git" as the update channel, there are some APIs to read it

Aug 04 '22 09:08 PVince81

seems pef ci fails because of viewer, ex: https://github.com/nextcloud/server/runs/7844066536?check_suite_focus=true

Aug 16 '22 07:08 PVince81

https://github.com/nextcloud/server/blob/1c60ff5936bf9c8358072023aeafa8a7ccd0c800/core/shipped.json#L59 maybe?

Aug 16 '22 19:08 skjnldsv

https://github.com/nextcloud/server/blob/1c60ff5936bf9c8358072023aeafa8a7ccd0c800/core/shipped.json#L59 maybe?

but then viewer won't be enabled by default anymore if I understand correctly :(

Also the ci is currently unhappy with my fix :(

Aug 17 '22 08:08 CarlSchwan

@CarlSchwan adding to shipped.json is independent from "default_enable". most other shipped apps are also enabled by default, ex: user_status

Aug 17 '22 08:08 PVince81

@CarlSchwan adding to shipped.json is independent from "default_enable". most other shipped apps are also enabled by default, ex: user_status

The difference is that you can disable user_status without issues.

Aug 17 '22 10:08 skjnldsv