server icon indicating copy to clipboard operation
server copied to clipboard

Solution for #6889

Open SpamReceiver opened this issue 4 years ago • 8 comments

See also: https://github.com/nextcloud/documentation/pull/7046

SpamReceiver avatar Nov 26 '21 21:11 SpamReceiver

@SpamReceiver sorry for coming back to you so late. Can you please rebase this to retrigger the CI? Thank you! :)

szaimen avatar Apr 07 '22 15:04 szaimen

Help! What do I need to do to complete this ticket?

SpamReceiver avatar Jun 24 '22 21:06 SpamReceiver

@SpamReceiver you need to sign off your commits, see https://github.com/nextcloud/server/pull/29929/checks?check_run_id=6858670749

PVince81 avatar Jun 30 '22 13:06 PVince81

@SpamReceiver you need to sign off your commits, see https://github.com/nextcloud/server/pull/29929/checks?check_run_id=6858670749

Thank you very much for this link.

Unfortunately, I have done the edits via the Web GUI and have no local git. Is there a way to fix it?

I discovered "xxx commits behind master" --> "Festch and merge", and now I have another commit, but there was no way to enter a commit message. :-(

SpamReceiver avatar Jul 03 '22 12:07 SpamReceiver

Hi @SpamReceiver, if you do not want to do it locally, you can otherwise simply create your change from the github web gui on a new branch and open a new PR with that! Do not forget to sign-off your changes directly though!

szaimen avatar Jul 04 '22 14:07 szaimen

Hi @SpamReceiver, if you do not want to do it locally, you can otherwise simply create your change from the github web gui on a new branch and open a new PR with that! Do not forget to sign-off your changes directly though!

Okay, I downloaded 2.5G via the clone command and followed the instructions here: https://github.com/nextcloud/server/pull/29929/checks?check_run_id=6858670749

Now, this thing still displays "Merging is blocked".

What am I supposed to do now?

SpamReceiver avatar Jul 13 '22 20:07 SpamReceiver

What am I supposed to do now?

Try to do your changes again here https://github.com/nextcloud/server/edit/master/config/config.sample.php and create a new PR from that :)

szaimen avatar Jul 14 '22 09:07 szaimen

What am I supposed to do now?

Try to do your changes again here https://github.com/nextcloud/server/edit/master/config/config.sample.php and create a new PR from that :)

New pull request: https://github.com/nextcloud/server/pull/33470

Please review!

SpamReceiver avatar Aug 05 '22 18:08 SpamReceiver

Superseded by https://github.com/nextcloud/server/pull/33470

szaimen avatar Aug 21 '22 10:08 szaimen