passman-android icon indicating copy to clipboard operation
passman-android copied to clipboard

Translation broken

Open obimichael opened this issue 3 years ago • 17 comments

In German I only see the following text: Benötigt keine Übersetzung. Hier wird nur die formelle Übersetzung verwendet. (de_DE) I tried to find to change to English, but with no luck. Version: 1.4.0-gplay

obimichael avatar Oct 16 '22 11:10 obimichael

Hi @obimichael, wo genau siehst du denn diesen Übersetzungsfehler? Die App verwendet zur Anzeige die eingestellte Systemsprache.

binsky08 avatar Oct 16 '22 13:10 binsky08

Hallo, einfach überall wo ein Text stehen sollte und keine Daten. Anbei exemplarisch ein Bild von den Einstellungen

configuration-passman-android

obimichael avatar Oct 16 '22 16:10 obimichael

Hi @rakekniven you do things with translation and transifex for nextcloud projects, right? It seems that Transifex does strange things and has moved some translation, for example, from the "values-de" folder to "values-de-rDE". This then apparently ends in these strange representations in our current release ^. See this example: https://github.com/nextcloud/passman-android/blob/15970c51e17388f2c551a2576f603fddbdbab920/app/src/main/res/values-de/strings.xml

Any idea what we can do to fix that?

binsky08 avatar Oct 16 '22 16:10 binsky08

Hello Timo,

for Nextcloud the germans are the only language which is maintaining two versions. See https://help.nextcloud.com/t/ubersetzungswissen-gultig-fur-das-komplette-nextcloud-projekt-wiki/59850#wieso-zwei-sprachen-3 for details.

The desktop client, ios and android app is using the de_DE version. Please make sure you are doing the same please.

Some weeks ago their was a move to the v3 version of the TX client (old one will be shut down in days). The migration run changed the config. See https://github.com/nextcloud/passman-android/commit/99af805cabdec1406f3a9c8b7753ffc414294b29

All valid strings are now in https://github.com/nextcloud/passman-android/blob/master/app/src/main/res/values-de-rDE/strings.xml

Does that help?

rakekniven avatar Oct 17 '22 07:10 rakekniven

I would recommend to check how other android apps of Nextcloud are handling this.

rakekniven avatar Oct 17 '22 07:10 rakekniven

@obimichael I tried the versions published via google play and fdroid and I didn't encounter any problems with the German translation on my device. You may be able to try to use German (formal) in your device.

binsky08 avatar Oct 19 '22 15:10 binsky08

Fixed on the sync server, sorry about that.

nickvergessen avatar Oct 19 '22 15:10 nickvergessen

There was a temporary error, that lead to the assumption a workaround we had in place is not needed anymore. We reverted back to the workaround today and it fixed the Nextcloud files and talk clients already. All other apps should follow tonight.

I tabbed the sync of this app manually for now.

nickvergessen avatar Oct 19 '22 15:10 nickvergessen

Ref https://github.com/nextcloud/docker-ci/pull/450

nickvergessen avatar Oct 19 '22 15:10 nickvergessen

Back again: https://github.com/nextcloud/passman-android/commit/4b144110b943b14a6f7f2a6ae05545a09c022788

nickvergessen avatar Oct 19 '22 15:10 nickvergessen

Will the next sync respect this change? the tx.config changed as well.

rakekniven avatar Oct 20 '22 06:10 rakekniven

It already did sync, so yeah?

nickvergessen avatar Oct 20 '22 07:10 nickvergessen

Looks good ! Guess this issue can be closed.

rakekniven avatar Oct 20 '22 08:10 rakekniven

@binsky08 thanks for your help!

My default Language is "German (Austria)" [Deutsch (Österreich)] , if I change to German (Germany) [Deutsch (Deutschland)] it is working correct. If i change back to "German (Austria)" I only see the text as you see on the Screenshot.

obimichael avatar Oct 20 '22 08:10 obimichael

Ok, this looks like a fallback from de_AT to de. Could you try if it the same for german swiss?

rakekniven avatar Oct 20 '22 09:10 rakekniven

@rakekniven With language "German Swiss", it looks like the same as with "German Austria".

obimichael avatar Oct 20 '22 11:10 obimichael

Ok, so my assumption about the fallback is right.

Not sure if the app can handle the fallback itself or only Android is handling it.

rakekniven avatar Oct 20 '22 12:10 rakekniven

should be fixed with v1.4.1

binsky08 avatar Feb 25 '23 23:02 binsky08