nextcloud
make code-blocks nicer
Nice!
- How does the
singular line blockplay out when there is more text in the line? - Is the leading Space in the "new" sample intented? Where does it come from? Or has it wrongly been stripped in the "old" sample?
- How does the singular line block play out when there is more text in the line?
Oh yeah, it breaks in a funny way. I will have to see if this can be fixed easily.
- Is the leading Space in the "new" sample intented? Where does it come from? Or has it wrongly been stripped in the "old" sample?
That is a bug. I guess it is due to the padding applied to give the content a bit more space, but it seems it is only applied to the first line.
That is a bug. I guess it is due to the padding applied to give the content a bit more space, but it seems it is only applied to the first line.
Without having a look into it, the behaviour hints for a CSS text-indent property. Maybe there is one which needs to be overridden :shrug:
Looks good :) Just for clarification: This is only for code blocks (three backticks), and not for inline code (one backtick), right?
Both! Block 1&2 in the screenshot are single ticks, 3 is block.
But now that you say it, let me check how well that behaves inside a larger text. Maybe i need to not apply a padding there
I fixed the issue for textblocks with quotes, but multiline-singleline-blocks look a bit worse than before. I dont think that is fixable, but maybe that is a tradeoff
@newhinton Thanks for your PR, this looks good! And thanks @stefan-niedermann for the review!
@newhinton What's the state of this PR? Are all issues fixed? Is this ready for final review? Could you please update the screenshots?
Looks very nice! Will add this to the 4.6.0 release, after the pre-wrap is fixed :tada: