notes-android icon indicating copy to clipboard operation
notes-android copied to clipboard

Edit button overlaps content

Open IngoBelka opened this issue 1 year ago • 10 comments

This issue respects the following points:

Describe the bug

  1. start app
  2. open a note
  3. scroll down to the end
  4. Edit button overlaps the last lines of the note

Expected behavior

no overlapping of content bring back the edit icon in menu line

Notes Android version

4.3 f-droid

Notes server version

4.10

Nextcloud Android version

3.29.1 f-droid

Nextcloud version

27.1.8

Device

Huawei media pad

Android Version

9.1

App Store

  • [ ] Google Play Store
  • [X] F-Droid
  • [ ] Huawei App Gallery

Stacktrace

No response

IngoBelka avatar Jul 08 '24 18:07 IngoBelka

Please, this annoying button shouldn't be too hard to fix. The function of this floating button would be clear enough if it only showed the pen icon and nothing more. It would be better to offer an option in the settings, which editor (plain/rich) should be preferred. Current screenshot:

Image

Buntbart avatar Oct 18 '24 12:10 Buntbart

Please, this annoying button shouldn't be too hard to fix.

Did you just volunteer? 😊

pbek avatar Oct 18 '24 12:10 pbek

If I could program, I would have already offered. But since it's only a very small change, I strongly suspect that it shouldn't take much more effort for people who can do that than replying to people who post error messages here.

Buntbart avatar Oct 18 '24 13:10 Buntbart

But since it's only a very small change

Ah, sorry, I assumed you have expertise in Java and the code base by stating that it is only a very small change. 😉

pbek avatar Oct 18 '24 13:10 pbek

Edit: sarcasm removed...

No, I have not. How much effort does it take to change the label of a button without changing it's functionality?

Buntbart avatar Oct 18 '24 13:10 Buntbart

How much effort does it take to change the label of a button without changing it's functionality?

Do you think that fixes the issue?

Small disclaimer: I'm not a maintainer of this project.

pbek avatar Oct 18 '24 13:10 pbek

It would be helpful to tag issues open to contributions as such, and share what the project maintainers expect as a fix for this issue because there are design concerns behind.

There are many solutions I can think of:

  1. Get back to old behavior: no FAB button => fine for me, but I'm not sure there is another way to access the advanced editor for people who like this, right?
  2. Add a safe zone: no text behind the FAB button, the textarea stops above the button
  3. Move the button as an option of the 3 dots menu
  4. Move the option as a global preference

Depending on your choice (or any other not listed), the fix can be very easy or requires more knowledge of the code for someone outside the project. At first sight, someone familiar with the code shouldn't be having too much difficulty applying one of the option I suggested (but I get you are volunteers and you might have other priorities).

papjul avatar Oct 18 '24 13:10 papjul

Do you think that fixes the issue?

For my needs, this would solve the problem.

Buntbart avatar Oct 18 '24 13:10 Buntbart

Imo tabs could be well-suited: a preview, plain edit and rich edit tab?

looowizz avatar Feb 02 '25 13:02 looowizz

#1904, which was added in response to #1819, may help some of you here.

joshtrichards avatar Apr 19 '25 14:04 joshtrichards

This bug was annoying enough that I filed a Pull Request (#2672). Let's keep fingers cross that the PR gets accepted, and a new version is released soon.

fm-sys avatar Jun 17 '25 21:06 fm-sys

Yesterday, I updated to 4.4.0 (F-Droid) and unfortunately, now I can no longer edit at the bottom of the text because it is covered by the keyboard.

Buntbart avatar Jul 25 '25 15:07 Buntbart