notes-android icon indicating copy to clipboard operation
notes-android copied to clipboard

Use the new Android 12 SplashScreen API

Open salixor opened this issue 3 years ago • 3 comments

Migration reference : https://developer.android.com/guide/topics/ui/splash-screen/migrate

Here's a before / after for Android 12 with the SplashScreen API (API level 31). Currently, the custom splash screen is ignored due to the new API (and uses the app icon by default) :

Before After
image image

And for reference, a before / after for API levels < 31 :

Before After
image image

salixor avatar Jul 06 '22 08:07 salixor

Awesome! I guess the support lib you added will take care of handling it for older API versions?

stefan-niedermann avatar Jul 06 '22 11:07 stefan-niedermann

Yes, it's a backwards compatibility lib Google provides to ease migrating to the new Splash API, and which they use in their migration guide

salixor avatar Jul 06 '22 12:07 salixor

  • Optional question: Will we need to add the splashscreen also to the EditNoteActivity? It can be launched directly, for example from widgets. (I think we are not doing this yet and I am not sure whether this has other implications)
  • Will this affect existing installations, for example vanished or unusable launcher links on created at their homescreens?

stefan-niedermann avatar Jul 18 '22 07:07 stefan-niedermann

Optional question: Will we need to add the splashscreen also to the EditNoteActivity? It can be launched directly, for example from widgets. (I think we are not doing this yet and I am not sure whether this has other implications)

Currently no changes in those regards has been done. This won't work any better or worse than before the changes, but we might have a look in the future to enhance the splashscreens for such "non-primary" actions

Will this affect existing installations, for example vanished or unusable launcher links on created at their homescreens?

Tested on an emulated and a physical Android 12 device: Existing shortcuts will continue to work.

stefan-niedermann avatar Aug 10 '22 10:08 stefan-niedermann