notes-android icon indicating copy to clipboard operation
notes-android copied to clipboard

Opening note from widget when device credentials is enabled empties the note.

Open hugalafutro opened this issue 4 years ago • 3 comments

Please use GitHub reactions 👍 to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!

Describe the bug

I enabled Device Credentials security in the Notes app to prevent accidentally opening notes by touching homepage widget. However when I touch the widget now and scan my fingerprint - the note opens as blank and the data is gone and I have to roll back the version in Nextcloud Files to get it back.

To Reproduce Steps to reproduce the behavior:

  1. Enable Device Credentials in Security options of the Notes app
  2. Exit the app
  3. Create a homepage Notes widget
  4. Touch any note in the widget
  5. Device will ask for its biometric/pattern/pin lock
  6. Unlock
  7. The note that will load will be empty and the data will be gone

Expected behavior The note should display normally

Screenshots

N/A

Smartphone (please complete the following information):

  • Nextcloud Notes-Version (android app): 3.4.16
  • F-Droid or Play Store: Play Store
  • Android-Version: 11
  • Device: OnePlus 6T with OxygenOS 11.1.1.1

Server

  • Nextcloud version: 22.2.0
  • Nextcloud Notes version (server app): 4.1.1

Stacktrace No ide what that is. There is nothing coming up in NC server log while this is happening.

hugalafutro avatar Oct 18 '21 09:10 hugalafutro

Thank you for the report, this is indeed a serious issue, i'll have a look as soon as possible.

No ide what that is.

No problem, a stacktrace is an error log that appears in case the app crashes - Since you didn't experience an actual crash, you can't insert a stacktrace of course.

stefan-niedermann avatar Oct 18 '21 09:10 stefan-niedermann

Workaround

For anyone else running into this issue: Hit the three dots menu in the top right corner and choose Cancel. This should prevent data loss in case you don't have the versions app enabled.

stefan-niedermann avatar Oct 18 '21 09:10 stefan-niedermann

First shot in the dark: Suspecting EditNoteActivity#onNewIntent to set a for the EditNoteActivity useless Intent with its origin at the unlocking mechanism. Maybe we can filter here for the type of intent.

stefan-niedermann avatar Oct 18 '21 09:10 stefan-niedermann