nextcloudpi icon indicating copy to clipboard operation
nextcloudpi copied to clipboard

(Optionally) run ncp apps in tmux

Open theCalcaholic opened this issue 6 years ago • 8 comments

I'm still testing this, but I figured, it wouldn't hurt to create a PR for reviewing/discussing.

This implements the execution of ncp apps in tmux if 'tmux: true' i set in their config. For most purposes, I've tried to make an app to behave exactly the same when run via tmux as it does conventionally.

Features:

  • [x] Run ncp apps in tmux (if configured)
  • [x] Check if ncp app is already running in tmux before starting it
  • [x] Load ('attach' to) execution output ~when selecting an ncp app in the web interface if it is running in tmux~ when attempting to launch an app from the web interface while one is running already

theCalcaholic avatar Feb 08 '19 22:02 theCalcaholic

Alright, I consider this PR complete now. Feel free to review and request changes :)

@nachoparker

theCalcaholic avatar Feb 17 '19 21:02 theCalcaholic

Looking better and better. So we are left with

  • update.sh
  • remove unused args

I know it's in progress, just making a list

nachoparker avatar Feb 20 '19 00:02 nachoparker

@nachoparker Hm, what's missing in update.sh?

theCalcaholic avatar Feb 20 '19 07:02 theCalcaholic

Like I said above ;)

Also, in update.sh, move /var/log/ncp.log to the new location it if exists, also update the contents of /home/www/ncp-launcher.sh

nachoparker avatar Feb 22 '19 04:02 nachoparker

Like I said above ;)

Also, in update.sh, move /var/log/ncp.log to the new location it if exists, also update the contents of /home/www/ncp-launcher.sh

Oh the log is already being moved in update.sh

EDIT: See update.sh, line52

theCalcaholic avatar Feb 22 '19 22:02 theCalcaholic

Looking better and better. So we are left with

* update.sh

* remove unused args

I know it's in progress, just making a list

Implemented in a357f2cdd45b97eb8685440b935ca5c00e30d4cc and aaa4202d2bb8d9360a66c2b22703630ada44868c

theCalcaholic avatar Feb 22 '19 22:02 theCalcaholic

hi Tobias, I was going to merge this but it looks that there are some conflicts. Could you merge with the latest devel real quick? I have some time next week and it would be nice to introduce this

nachoparker avatar May 26 '19 01:05 nachoparker

Ah, damnit. I didn't see your message until now. It's will probably require some effort now to merge all the changes that have been made by now...

theCalcaholic avatar Jul 28 '19 13:07 theCalcaholic