news-android icon indicating copy to clipboard operation
news-android copied to clipboard

Update ci.yml

Open vigyanhoon opened this issue 4 years ago • 1 comments

vigyanhoon avatar May 25 '21 03:05 vigyanhoon

Hello and thank you for the contribution.

Would you elaborate your changes please? I see no reason to put an unsigned prod build to the output artifacts...?

The app should never be used directly from GitHub if you are not a developer because

  • It is unsigned and therefore a potential security risc
  • It won't receive any automatic updates. Installing updates provided by an App store will fail to install due a different / missing certificate - also a potential security risc
  • It can't be identified properly, while the debug build has a unique icon

Lookkng forward to your response 🙂

stefan-niedermann avatar May 25 '21 05:05 stefan-niedermann

@vigyanhoon feel free to comment if you're still interested in this PR

Unpublished avatar Apr 07 '23 13:04 Unpublished