news-android icon indicating copy to clipboard operation
news-android copied to clipboard

Starred items are listed backwards

Open LinAGKar opened this issue 3 years ago • 1 comments

If you set the app to list articles in chronological order, starred items are still showed in reverse chronological order.

LinAGKar avatar Apr 27 '22 07:04 LinAGKar

Thank you for the report - I agree, that the starred items should follow the selected order. I'll fix this in the next update.

David-Development avatar May 01 '22 13:05 David-Development

Can I give this issue a go or has it already been implemented?

mkanilsson avatar Sep 06 '23 17:09 mkanilsson

@mkanilsson For sure!

As a bonus - I'm wondering if it makes sense to keep the following feature request in mind: https://github.com/nextcloud/news-android/issues/1026. It could be implemented as an option when the user long presses a feed (when you open the sidebar and long press a feed you get a few extra options/settings for the feed)

When you start on this it might make sense to use the Material 3 branch as a base branch because it is almost done and will be merged soon. This way we probably prevent a lot of merge conflicts in case you make some changes to the UI (https://github.com/nextcloud/news-android/pull/1186).

David-Development avatar Sep 07 '23 03:09 David-Development

I could make it 2 PRs, one that fixes this issue and one that implements the feature request.

The feature request might be over my ability since I have 0 experience in android app development, but I'll give it a try!

mkanilsson avatar Sep 07 '23 13:09 mkanilsson

@mkanilsson Sounds great! No worries, let me know if you have any questions!

David-Development avatar Sep 07 '23 14:09 David-Development

@mkanilsson It probably makes sense to integrate it into the NewsReaderListDialogFragment (Link) in a similar fashion that the Notification Settings are implemented there. There are more feature requests open that could be added there as well (e.g. https://github.com/nextcloud/news-android/issues/1221).

David-Development avatar Sep 08 '23 05:09 David-Development

Moving the discussion over to #1026 as it seems more appropriate.

mkanilsson avatar Sep 08 '23 15:09 mkanilsson