neon icon indicating copy to clipboard operation
neon copied to clipboard

Improve server icons

Open provokateurin opened this issue 1 year ago • 7 comments

https://github.com/nextcloud/server/blob/master/core/src/icons.js generates the CSS rules for the server icons. It is more complex than our naive approach, so not everything works (almost everything does though). We should follow the code in the script and map our icons accordingly. Instead of parsing that file it should be easier to just parse https://github.com/nextcloud/server/blob/master/dist/icons.css and extract the icon names and SVGs from there.

provokateurin avatar May 03 '24 05:05 provokateurin

May I work upon this issue?

devesh-2002 avatar May 03 '24 06:05 devesh-2002

Sure! Let me know if you need any help. The existing script that generates the icons is at https://github.com/nextcloud/neon/blob/main/tool/generate-assets.sh

provokateurin avatar May 03 '24 06:05 provokateurin

@devesh-2002 how is it going? Do you have questions or need help implementing it?

provokateurin avatar May 08 '24 16:05 provokateurin

Hello. I am very sorry I was not able to work upon this PR due to certain reasons. I will work upon it this week and update regarding it.

devesh-2002 avatar May 08 '24 18:05 devesh-2002

No problem, I was just wondering if you needed any pointers.

provokateurin avatar May 08 '24 18:05 provokateurin

I had a closer look at this and it is quite a lot harder than I thought. Might not even be worth to put in the time to fully implement it unless we know something is actually broken.

provokateurin avatar May 17 '24 11:05 provokateurin

The easier way might even be to implement a new API in the server that allows resolving these icons (which could also be used in the CSS to avoid embedding all the SVGs).

provokateurin avatar May 17 '24 11:05 provokateurin