add to favorites from search does not work anymore

[ebiagi]

Php 7.4 Nextcloud 24.0.3

searching an address from the search bar and trying to add the result to favorites it's not working anymore (neither the add contact address is), clicking on it doesn't trigger any action or

I've tried with a couple of browsers (firefox, chromium, librewolf) and disabling all privacy restrictions, I've also tried Edge with basic settings

[meierwitt]

Hi,

same here, PHP 7.4.3 and Nextcloud 24.0.4. Can't add an favorite to map, can't add new category.

Thanks, Frank

[odea]

Hi, same here, PHP 7.4.3, NC 24.0.5. Tried disable privacy addons in firefox. No javascript errors. It's a major feature ! Thanks

[odea]

Hi, any update on this one ? It still doesn't work with maps 0.2.4, NC 25.0.2

[tacruc]

Can Anyone confirm that #933 fixes this Issue?

[odea]

Hi, Thanks ! but I edited the 3 files and still unable to add favorite from a search result.

[tacruc]

You will have to build the java script. Something along the lines: npm ci npm run build or npm run watch to automatically rebuild the files, while developing.

[odea]

Hmm the thing is ... I'm not a good dev :) I stopped at C & PHP. I tried to install npm, tried npm ci but it can't find packages.json, I only have package-lock.json....I will fall into the rabbit hole if I go any further :)

[tacruc]

https://github.com/nextcloud/maps/releases/tag/v0.2.5-2-933-nightly

I created a nightly release with this.

[odea]

Thanks ! I tried to untar the .tar.gz in the apps folder, nextcloud updated it self automatically but I don't why but now a lot of things are missing : search bar, my favorites, etc.. did I missed something in the process ?

[odea]

I have those js errors : TypeError: Function.prototype.bind called on incompatible target easyButton easy-button.js:320 initLayers Map.vue:774 onMapReady Map.vue:434 VueJS 4 mounted LMap.js:354 VueJS 9 mounted LMap.js:342 VueJS 13 gw main.js:97 restoreOptions optionsController.js:44 promise callback*restoreOptions optionsController.js:41 <anonymous> main.js:93 EventListener.handleEvent* main.js:87 <anonymous> main.js:94 <anonymous> main.js:94 vue.runtime.esm.js:3049:16 VueJS 7 mounted LMap.js:354 VueJS 9 mounted LMap.js:342 VueJS 13 gw main.js:97 restoreOptions optionsController.js:44 (Asynchrone : promise callback) restoreOptions optionsController.js:41 <anonyme> main.js:93 (Asynchrone : EventListener.handleEvent) <anonyme> main.js:87 <anonyme> main.js:94 <anonyme> main.js:94

[tacruc]

Ok, found the Issue. Apparently there is an incompatibility with the talk app. Both are loading different leaflet modules which seems to make problems. You could test, when disabling the talk app. Otherwise this Issue has to be resolved first.

[odea]

Oh yeah indeed ! works like a charm now with talk disabled :) thanks !

[odea]

Maybe the initial issue was the talk app and not maps ?

[tacruc]

No it wasn't working, before the fix. And with the talk app incompatibility it's probably a shared responsibility.

[odea]

Thanks for your time !