nextcloud
[Draft] Collaborative Maps Nextgov Hackathon
Codecov Report
Base: 57.09% // Head: 52.38% // Decreases project coverage by -4.70% :warning:
Coverage data is based on head (
efd8da8) compared to base (3518285). Patch has no changes to coverable lines.
Additional details and impacted files
@@ Coverage Diff @@
## master #731 +/- ##
============================================
- Coverage 57.09% 52.38% -4.71%
- Complexity 1153 1409 +256
============================================
Files 47 49 +2
Lines 3540 4255 +715
============================================
+ Hits 2021 2229 +208
- Misses 1519 2026 +507
| Flag | Coverage ฮ | |
|---|---|---|
| unittests | 52.38% <รธ> (-4.71%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage ฮ | |
|---|---|---|
| nextcloud/apps/maps/lib/DB/FavoriteShareMapper.php | 50.57% <0.00%> (-42.91%) |
:arrow_down: |
| ...loud/apps/maps/lib/Controller/PhotosController.php | 58.18% <0.00%> (-41.82%) |
:arrow_down: |
| ...loud/apps/maps/lib/Controller/TracksController.php | 63.07% <0.00%> (-23.37%) |
:arrow_down: |
| ...d/apps/maps/lib/Controller/FavoritesController.php | 72.97% <0.00%> (-22.11%) |
:arrow_down: |
| ...tcloud/apps/maps/lib/Controller/PageController.php | 88.73% <0.00%> (-11.27%) |
:arrow_down: |
| ...cloud/apps/maps/lib/Controller/UtilsController.php | 7.04% <0.00%> (-3.22%) |
:arrow_down: |
| ...extcloud/apps/maps/lib/Service/GeophotoService.php | 92.26% <0.00%> (-1.11%) |
:arrow_down: |
| ...ud/apps/maps/lib/Controller/ContactsController.php | 9.03% <0.00%> (-0.74%) |
:arrow_down: |
| nextcloud/apps/maps/lib/Command/RescanPhotos.php | 0.00% <0.00%> (รธ) |
|
| nextcloud/apps/maps/lib/Service/DevicesService.php | 73.95% <0.00%> (รธ) |
|
| ... and 6 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@CarlSchwan thanks for the partial review.
For review it might be helpfull to know, that based the branch so that it includes some important bug fixes.
Im on my phone so I cannot give a complete list right now but most are listed in https://github.com/nextcloud/maps/issues/732
It seems that I can't rename a map from the interface (I tried with just hitting [Enter] and also clicking the arrow button). In order to rename "New map" I had to alter the directory name under Maps/
I'm also unable to delete a favorite. I can do so on the default map but none of the ones I create.
A design critique: Clicking on any of the side items in the map toggles the item on and off. This new feature switches between maps rather than toggles, breaking the consistency of the sidebar. Perhaps this would be better as a drop-down menu or something.
Really nice work!
It seems that I can't rename a map from the interface (I tried with just hitting [Enter] and also clicking the arrow button). In order to rename "New map" I had to alter the directory name under Maps/
Should be fixed now
I'm also unable to delete a favorite. I can do so on the default map but none of the ones I create.
Should be fixed too
Thanks for all your great work, @tacruc!
Thanks for testing this is really helpful.
Hi @tacruc, I don't usually ask this sort of question, it makes me really uncomfortable, but my interest in this functionality, especially the trip planning part, is so big that I'm bringing it up nevertheless, always with all the due respect for you and your work: how far are you with the implementation of the trip planning functionality?
Background: We made last year a long trip to the north of Europe, and now we are creating a travel photo book about it. In such cases, usually we copy a map with the itinerary colored by hand into it. We also have another trip coming up in March, this time to the south, for which we start planning in February. I have my own Nextcloud server, and of course it would be very nice if we could use your app for these tasks. The Maps application is installed in the latest version โI mean, the nightly unstableโ and at current state I'm able to define new maps, but then can do absolutely nothing with. What I will do later on this weekend is creating a tracking file with the itinerary and trying to read it in. That would be a perfect fallback solution for the photo book task.
It worked without until now, so, absolutely no stress, but if this functionality will be available soon, then we would be enthusiastic and real use case testers... Regardless of that, I take the opportunity here to thank you and others very much for the time and effort that you all invest in the conception and further development of all the fantastic solutions.
Kind regards.
@JMLatGitHub,
always with all the due respect for you and your work: Thanks,
how far are you with the implementation of the trip planning functionality?
In currently working in public pages, as they are in focus of my personal use case. Having those I hope that I will find some more bugs in order to fix them before the first stable release.
'm a little surprised by one sentence of ours.
I'm able to define new maps, but then can do absolutely nothing with. You should be able to do everything you could do previously with the maps app. Just now not on one but on multiple maps, which you can share. See screenshots in the readme. What did you expect to do?
Well, maybe I just don't understand how it works: I have a default map and a Scandinavia map, but since the update (or since the creation of the Scandinavia map, I'm not sure) absolutely no objects are displayed on the maps, no photos, no contacts, no tracks, no devices, which were all visible before and were automatically updated when changes were made, e.g. new photos or contacts... I did already a re-scan but luckless.
By the way, what is the meaning/functionality of public pages?
since the update The update to v0.2.5-1-nightly or the update to v0.2.5-2-933-nightly? I'm just asking as before v0.2.5-1-nightly there shouldn't be any custom map. And if the change to v0.2.5-2-933 breaks something it would be important, as it was rather a small fix, which shouldn't break stuff.
So as I see it you have now two maps, default and Scandinavia.
So it looks like this?
Which of the two maps doesn't show content? Both? Or only Scandinavia?
How it should be: The Default Map should be everything as it used to be. The Scandinavia map should only show content which you added. (Right click Copy to map) Or by uploading e.g. photos into the related folder. (Probably /Maps/Scandinavia)
By the way, what is the meaning/functionality of public pages?
Sofar you can share a map like a folder (a map is technically shared by sharing the folder), but only registered and logged in users will be able to view the map. As there is a public page missing which is viewable for not logged in visitors (E.g. people just have a public link to the share).
Well, I'm pretty sure I had all objects after updating from stable to the newest nightly just before creating the additional Scandinavia map. Now, my setup is as described by you. Additionally, I have My contacts (13), My photos (99+), My tracks (6) and My devices (1) listed, but nothing is shown on none of the two maps.
Thanks for the explanation about the public pages. Nice functionality indeed.
Ok can you check the browser console? Additionally can you check if the time slider is enabled? Can you disable it?
Here we go. Slider now disabled. Attached the browser console log accessing Maps: 3rdlvld.2ndlvld.tld-1674484798913.log.
As I see it, there are errors that are directly related to the Maps application. Beside these, there are also error messages referencing the push service that I have to verify/fix, but these should not affect the functionality of the Maps application, right?
Kind regards
Is it possible for you to temporally disable the talk app and see if that helps?
Another question: For trip planning, especially for longer trips, I think it would be desirable if it would be possible to define individual stages and color them differently or show and hide the individual sections. Also be able to assign different line types or even the possibility to determine the line thickness would also be nice features. Is something like this planned or envisioned?
Hello again. With the latest nightly map app (V0.2.5-4), I can finally create trips, but only under my admin account. With the normal user accounts, only "Add a favorite", "Place photos", "Place contact" and "Share this location" are available. Is this a known issue/limitation, @tacruc?
Another issue is that if you export a route, the corresponding GPX route or track is saved with a filename containing the current time in the format of hh:mm:ss. Colon is an unsupported character under Windows and leads to error messages when trying to synchronize.
Best regards