maps icon indicating copy to clipboard operation
maps copied to clipboard

l10n: Add plural handling to a few js strings

Open rakekniven opened this issue 5 years ago • 8 comments

Reported at Transifex.

https://github.com/nextcloud/maps/blob/9cdfbe18306a06d8128260f3c01ee0580ef77bd1/src/photosController.js#L633

rakekniven avatar Nov 10 '20 09:11 rakekniven

This still needs to be changed:

  • {nb} favorites imported from {path}

https://github.com/nextcloud/maps/blob/b3ff4d0aeb29ae0367b39339022249c72ea004ab/src/favoritesController.js#L1275 https://github.com/nextcloud/maps/blob/b3ff4d0aeb29ae0367b39339022249c72ea004ab/src/filetypes.js#L31

  • closes in {nb} minutes

https://github.com/nextcloud/maps/blob/b3ff4d0aeb29ae0367b39339022249c72ea004ab/src/script.js#L1979

  • {nb} photos reset

https://github.com/nextcloud/maps/blob/b3ff4d0aeb29ae0367b39339022249c72ea004ab/src/photosController.js#L671

  • {nb} devices imported from {path}

https://github.com/nextcloud/maps/blob/b3ff4d0aeb29ae0367b39339022249c72ea004ab/src/devicesController.js#L1135 https://github.com/nextcloud/maps/blob/b3ff4d0aeb29ae0367b39339022249c72ea004ab/src/filetypes.js#L53

You should rely on this code: https://github.com/nextcloud/server/blob/a2a3b87c19662f06cfb804b9fead7e939b1c3e6c/core/src/globals.js#L139-L148

Valdnet avatar Nov 13 '20 16:11 Valdnet

@eneiluj You maybe?

rakekniven avatar Nov 13 '20 17:11 rakekniven

ping @eneiluj

Valdnet avatar Mar 19 '21 13:03 Valdnet

Is it fixed in the new frontend?

tacruc avatar Jun 16 '22 11:06 tacruc

No, AFAICS from code.

rakekniven avatar Jun 20 '22 12:06 rakekniven

The correct files is now: https://github.com/nextcloud/maps/blob/883e53795917bbad3bbf48295615c786f01d77f7/src/views/App.vue#L1726

tacruc avatar Jun 21 '22 19:06 tacruc

But the file I linked to in my initial post is still there in master branch?

rakekniven avatar Jun 27 '22 13:06 rakekniven

The old JS code is not yet removed. Working on it see #724

tacruc avatar Jun 27 '22 21:06 tacruc