integration_google icon indicating copy to clipboard operation
integration_google copied to clipboard

Only the albums are imported

Open amgschnappi opened this issue 1 year ago • 2 comments

Which version of integration_google are you using?

Latest

Which version of Nextcloud are you using?

Latest

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

No response

Describe the Bug

Only the albums are imported. Photos which arent part of any albums are not imported.

Expected Behavior

All the photos should be imported, irrespective of whether they are part of album or not.

To Reproduce

Set the google integration and start the photos import.

Run cron.php in a loop.

Wait for many days.

Bug : Only albums are imported. Its expected that photos, which arent part of any albums, should also be imported.

amgschnappi avatar Aug 26 '24 14:08 amgschnappi

Hello :wave:

Thank you for taking the time to open this issue with integration_google. I know it's frustrating when software causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at and if possible solved. We try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until we get to it. Until then, please be patient. If you are strugging to set up the app, have a look at this video: https://www.youtube.com/watch?v=h_teJPg2wEk Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can collaborate to make this software better. For everyone. Thus, if you can, you could also look at other issues to see whether you can help other people with your knowledge and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and try to fix the odd bug yourself. Everyone will be thankful for extra helping hands! One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum, to twitter or somewhere else. But this is a technical issue tracker, so please make sure to focus on the tech and keep your opinions to yourself. (Also see our Code of Conduct. Really.)

I look forward to working with you on this issue Cheers :blue_heart:

github-actions[bot] avatar Aug 26 '24 14:08 github-actions[bot]

This is not a bug, it's a limitation of the current implementation, which does work as expected.

marcelklehr avatar Sep 02 '24 07:09 marcelklehr

Could you please add this as info/warning in the import screen? It is quite jarring if you notice that some images have not been imported when you are about to delete them in google drive.

Although I'm not sure, doesn't this code import images not in an album? https://github.com/nextcloud/integration_google/blob/main/lib/Service/GooglePhotosAPIService.php#L322

sargreal avatar Nov 01 '24 18:11 sargreal

I tried the import and it only finished 10 albums. I have more. Is there any logging that I can turn on to check what's going on? Thank you!

kalinbogatzevski avatar Dec 05 '24 18:12 kalinbogatzevski

This is now working as i expected. You can set this as fixed rather than enhancement.

amgschnappi avatar Jan 10 '25 13:01 amgschnappi