helm icon indicating copy to clipboard operation
helm copied to clipboard

Feature: Add Collabora as a subchart #611

Open kriegalex opened this issue 1 year ago • 1 comments

Description of the change

  • Add a dependency to the 1.1.20 collabora chart from their official repository
  • Add the subchart config to values.yaml
  • Add the configuration options documentation to README

Benefits

  • Install collabora as a subchart of nextcloud via helm

Possible drawbacks

  • People may try to enable it without knowing what is is and how to configure it (mainly extra_params, server_name, aliasgroups and annotations.

Applicable issues

  • fixes #611

Additional information

Tested on my local kubernetes cluster with a HTTPS nginx ingress. Nextcloud can communicate with Collabora. Not tested with HAProxy (though it is only a change in annotations specific to HAProxy).

Checklist

kriegalex avatar Aug 23 '24 13:08 kriegalex

Oh, awesome! Thanks, @kriegalex for this PR!

Right now the workflow is failing: https://github.com/nextcloud/helm/actions/runs/10956242340/job/30421859233?pr=623#step:7:16

You can fix this by adding the helm repo for collabora to this section of the workflow file, similar to how we do for bitnami: https://github.com/nextcloud/helm/blob/b25b4ad50bb46bb61947f9c35260f681d4706885/.github/workflows/lint-test.yaml#L39-L41

jessebot avatar Sep 20 '24 08:09 jessebot

Thanks for the change on lint tests. I'm still learning k8s, didn't think of that.

kriegalex avatar Sep 30 '24 12:09 kriegalex

Publishing the release failed: https://github.com/nextcloud/helm/actions/runs/12341432621/job/34440050803

provokateurin avatar Dec 15 '24 19:12 provokateurin

looking!

jessebot avatar Dec 15 '24 21:12 jessebot

let's see, the error was:

Error: no repository definition for https://collaboraonline.github.io/online

That does seem to be right according to the docs: https://github.com/CollaboraOnline/online/tree/master/kubernetes/helm/collabora-online#deploying-collabora-online-in-kubernetes

Ah! It's the actual release config that needs to have the collabora online helm repo added: https://github.com/nextcloud/helm/blob/10cae24593c059bab6135d3c829f898f97d97fad/.github/workflows/release.yaml#L35-L38

PR incoming!

jessebot avatar Dec 15 '24 21:12 jessebot

PR to fix release here: https://github.com/nextcloud/helm/pull/667

PR to release this change here: https://github.com/nextcloud/helm/pull/668

jessebot avatar Dec 15 '24 21:12 jessebot