nextcloud
fix: Adjust styles for Nextcloud 30 (default heading styles)
Adjusted the headings for https://github.com/nextcloud/server/pull/43640/files
I am wondering, are the server styles not applied here? Because maintaining these styles in all places sounds very demanding to me...
They are, but we need to adjust, as our h3 here e.g. for cards would be too big. they are fine if you use h2-h6 but we only have h2 and h3
They are, but we need to adjust, as our h3 here e.g. for cards would be too big. they are fine if you use h2-h6 but we only have h2 and h3
I see. then lets do it like that
Maybe we should also change the styles on server again to not use the h1 styles for h2 ... but just use h2 for h2 etc. Because for non text documents a that big h2 makes no sense and we need to adjust the styles everywhere.
Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.
We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.
Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6
Thank you for contributing to Nextcloud and we hope to hear from you soon!
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Should this get in @susnux?
we need to do so, probably adjusting the size a bit more
@susnux if it is an improvement over the current state than I'd say let's merge as-is and have a follow-up. If it doesn't improve the situation in the current state of the PR, than let's leave it open for now.
@AndyScherzinger yes we need this otherwise it does not properly fit Nextcloud 30
Thanks @susnux - merged. I think daily pulls master-branch also for this app. Hence we can look at it tomorrow 👍